search

charlottegiseleweil / natureforpeople

0 stars 1 forks source link

About and info button on risk_index and coastal #7

Open annfr542 opened 5 years ago

annfr542 commented 5 years ago

@AhmedAhres @charlottegiseleweil I added your navbar to our pages now, unfortunately there where a lot of css crashes so it doesn't look exactly the same. I also have a problem with the about and info pages since I don't understand the code that implements them in index.html

charlottegiseleweil commented 5 years ago

Look into the code in popup.js. If it still doesn't make sense @AhmedAhres or I can explain next week

annfr542 commented 5 years ago

Great! I added the popup.js before but I need to add some divs to the html as well and I can't figure out which. Also the popup.js is depending on some other code as well but hopefully it's fixable :)

charlottegiseleweil commented 5 years ago

Seriously you couldn't find the corresponding divs in index.html @annfr542 ?!

I had litteratlly annotated the code:

<!-- About Pop-up Window --> (index.html line 94) <!-- End of Pop-up Window -->

For the info-button one: <!-- Info Button Pop-up Window --> (index.html line 102)

... -_-

annfr542 commented 5 years ago

Of course I saw those @charlottegiseleweil, the problem I had was with a div called “3rd_box” that is required by popup.js. I can find where the div is opened in index.html but now where it’s closed. But I will have another look next time I work with it.

charlottegiseleweil commented 5 years ago

Oh interesting, I didn't even dig into it that much sorry! @AhmedAhres should be able to help ?

AhmedAhres commented 5 years ago

@annfr542 Try to replace "3rd_box" by the your big box container. The thing is that the popup is an overlay. "3rd_box" here is our "box_container" which is basically the box that contains everything you see in the screen. You can replace that by whatever you are using to put in everything in your viz!

annfr542 commented 5 years ago

@AhmedAhres we call this div "wrapper" maybe we could decide on a proper name together so we both can use the popup.js (we don't have to use wrapper but 3rd_box is not very initiative). Next problem; just as you I get the console error when I load the page: “Uncaught Error: No element option passed to Waypoint constructor at new t (noframework.waypoints.min.js:7) at popup.js:2” What is this and what do you use the “waypoint” for? Ignoring this problem, I still can’t show the about page, I don’t get any other error messages so could you please have a look. For now, I’m just trying with risk_index.html.