charlottesirot / elementR

8 stars 4 forks source link

bug when reducing standards and samples #10

Open kimdonesia opened 5 years ago

kimdonesia commented 5 years ago

This looks like a very useful package. I have had some trouble when trying to reduce my data.

I've found a similar problem to that reported by jenlewis. When trying to reduce my standards and samples (steps 2 and 4) the program frequently stalls and flickers back and forth between the last two samples. The only solution I have found is the relaunch the program, but I frequently have the same problem several times in a row.

charlottesirot commented 5 years ago

Hi Kim, Thank you very much for your comment. Someone warned me about this bug and I changed the version on the gitHub. You can try to install the software based on the gitHub version with the following commands:

#Install elementR's dependencies
pkgs <- c("gdata", "shiny","devtools", "shinyjs", "gnumeric", "R6", "shinydashboard",
    "abind", "stringr", "lmtest", "tcltk", "tcltk2", "reader", "readODS", "readxl", "outliers", "climtrends",
    "EnvStats", "colourpicker", "zoo", "httpuv")

invisible(lapply(pkgs, function(pkgs){
    if(!require(pkgs)){
        install.packages(pkgs, dependencies=TRUE)
    }
}))

#Install elementR
devtools::install_github("charlottesirot/elementR", ref = "master", force = T, dependencies = T)

library(elementR)

And see if it is better with this version. I would appreciate that, if you manage to try with this last version, you could post here whether the new version has less bug that goes back and forth.

Thank you very much for elementR

kimdonesia commented 5 years ago

Hi,

Thank you for sending me the modified code. That seemed to fix my initial problem.

I'm now getting a code when I go to the averaging samples step. I ran transects, but as soon as I select transects on step 5 I get the following error message: Warning: Error in if: missing value where TRUE/FALSE needed

Can you please provide me with some guidance on how to fix this?

Thanks again for writing this program. Once I get the bugs fixed I think it will be an extremely useful program!

Blessings, Kim

On Mon, Nov 5, 2018 at 3:09 AM charlottesirot notifications@github.com wrote:

Hi Kim, Thank you very much for your comment. Someone warned me about this bug and I changed the version on the gitHub. You can try to install the software based on the gitHub version with the following commands:

Install elementR's dependencies

pkgs <- c("gdata", "shiny","devtools", "shinyjs", "gnumeric", "R6", "shinydashboard", "abind", "stringr", "lmtest", "tcltk", "tcltk2", "reader", "readODS", "readxl", "outliers", "climtrends", "EnvStats", "colourpicker", "zoo", "httpuv")

invisible(lapply(pkgs, function(pkgs){ if(!require(pkgs)){ install.packages(pkgs, dependencies=TRUE) } }))

Install elementR

devtools::install_github("charlottesirot/elementR", ref = "master", force = T, dependencies = T)

library(elementR)

And see if it is better with this version. I would appreciate that, if you manage to try with this last version, you could post here whether the new version has less bug that goes back and forth.

Thank you very much for elementR

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/charlottesirot/elementR/issues/10#issuecomment-435803279, or mute the thread https://github.com/notifications/unsubscribe-auth/AqjYIAVwHfOB7WXfBuw4zukx2VE6fCLGks5usABIgaJpZM4YCsL1 .

-- Kimberly Peter Dauphin Island Sea Lab 101 Bienville Blvd. Dauphin Island, AL 36528 Phone: (251) 861-2141 ext.7547

charlottesirot commented 5 years ago

Hej Kim,

Sorry for the delay. Could you provide me some data (publicly or privately at elementR.software@gmail.com), so that I can reproduce the bug?

Have a good day !