search

charlottesirot / elementR

8 stars 4 forks source link

Version 1.3.8 for CRAN, resolving gdata dropping read.xls() #13

Open arni-magnusson opened 1 year ago

arni-magnusson commented 1 year ago

Hi, this pull request consists of 4 commits:

  1. Remove gdata dependency: this is the main thing, to make sure elementR stays on CRAN after gdata 3.0.0 is released, which is soon.

  2. Fix help page: delementR_repStandard -> elementR_repStandard: this typo was causing R CMD check --as-cran to warn that there was inconsistency between code and documentation.

  3. Fix https links: the old web links were causing R CMD check --as-cran to raise notes about redirected URLs.

  4. Remove Travis - service stopped in 2021: R CMD check --as-cran was also finding problems with the Travis link, a free web service that stopped working a couple of years ago.

With these changes, the elementR 1.3.8 can be submitted to CRAN.

charlottesirot commented 1 year ago

Thanks à lot! I will fix it as soon as possible. Don't hesitate to send a reminder if you see that nothing is moving, I am actually changing job so everything is a bit erratic.

Thanks again

Charlotte

Le jeu. 15 juin 2023, 03:11, Arni Magnusson @.***> a écrit :

Hi, this pull request consists of 4 commits:

1.

Remove gdata dependency https://github.com/charlottesirot/elementR/commit/2b0dbba: this is the main thing, to make sure elementR stays on CRAN after gdata 3.0.0 is released, which is soon. 2.

Fix help page: delementR_repStandard -> elementR_repStandard https://github.com/charlottesirot/elementR/commit/150ec7a: this typo was causing R CMD check --as-cran to warn that there was inconsistency between code and documentation. 3.

Fix https links https://github.com/charlottesirot/elementR/commit/5ae423c: the old web links were causing R CMD check --as-cran to raise notes about redirected URLs. 4.

Remove Travis - service stopped in 2021 https://github.com/charlottesirot/elementR/commit/ed66c7f: R CMD check --as-cran was also finding problems with the Travis link, a free web service that stopped working a couple of years ago.

With these changes, the elementR 1.3.8 can be submitted to CRAN.

You can view, comment on, or merge this pull request online at:

https://github.com/charlottesirot/elementR/pull/13 Commit Summary

File Changes

(6 files https://github.com/charlottesirot/elementR/pull/13/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/charlottesirot/elementR/pull/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTT747E54FVJENP7K4SKNDXLJOLVANCNFSM6AAAAAAZHDYJJ4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

arni-magnusson commented 10 months ago

Bump?