charlottesirot / elementR

8 stars 4 forks source link

Few bugs noticed #9

Open jenlewis opened 6 years ago

jenlewis commented 6 years ago

Thanks for a great package! It's saving me a load of time :) but I have noticed a few things recently:

In the standard sample reducing window there are a few different things.

charlottesirot commented 5 years ago

Hiiii Jen,

I am so sorry not to have been able to answer you before. So much work !!

Thanks a lot for your comment. Let's discuss bullet per bullet to be sure that I understand your comment correctly:

  1. You are right. Some features of the "settings" section change when you validate your session. It is actually to protect user to change some crucial calculations settings during the filtration. For instance, if at the beginning, he considers that the method of calculation of the outliers is Rosner Test for instance, it is important that this calculation stays consistent throughout the session filtration. Does it make sense for you? However, I am surprised that you say that you have to restart elementR to change the settings. If you go to the step 1 and press on "Start another project", would it be not more practical than re-launching elementR? Or did I misunderstood? For csvs, if you are using csvs, why not integrating this format in future versions of elementR :)

  2. You mean that you cannot define the plateau of the other standards ? This is absolutely not normal. You should be able to define the blank and the plateau as you want. Could we see that together one day, if you have the possibility to share screens on skype ? Yeah the kmean is supposed to help the user, but sometimes the data are really messy and for the algorithm it is confusing. Basically it is just a helper.

  3. For switching samples, I think I understand what you meant. Basically, elementR guides you to the next step, by changing the sample for you. So if you need to another standard than the next one you have to wait for him to have finished to "propose" the next standard to analyze. Is it what you mean ?

  4. Here again, it is not normal!! At this step you should be able to choose the type of data you need (corrected, normalized...) and it should not show you standard sample. Or did I misunderstood?

In any case, thank you very much for the time you took to do these comments. Again, if you have the time to skype to show me all that, I would be really interested.

Finally, you can participate to the survey concerning elementR https://goo.gl/forms/MEtt05MerRMctfTF3. It is really important that we understand the needs of elementR's users in order to be able to expand appropriately this free software. So don't hesitate to forward this survey to people that might be interested in elementR. The more the better!!

Cheers!!!