charltonator / pe

0 stars 0 forks source link

LinkedIn input field can be left as just linkedin.com/ #7

Open charltonator opened 3 years ago

charltonator commented 3 years ago

image.png

The linkedin Field which requires users to add their link to their profile allows for anything with the prefix linkedin.com/ , which means users could potentially simply not add the link to their personal linkedin profile.

nus-pe-bot commented 3 years ago

Team's Response

NetworkUS only ensure that the weblink for LinkedIn is in the correct format. NetworkUS does not restrict the user to what LinkedIn link they add to the contact.

In addition, there is no way for NetworkUS to check whether the LinkedIn link belongs to the contacts (just like how we can't confirm the phone number or the other detail is accurate, NetworkUS can only check that it is a valid format).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: if you really checked if it was valid format, you should have checked if it was empty. it's not a hard check to add code-wise. This is not checking if the linkedin link belongs to the contact. It's merely checking if it was even valid in the first place. and linkedin.com/ is not valid because its empty after the /.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]