search

charludo / ycms

Apache License 2.0
0 stars 0 forks source link

Feature/darkmode #101

Closed noworneverev closed 8 months ago

noworneverev commented 8 months ago

Short description

Add dark mode

Proposed changes

Side effects

Resolved issues

Fixes: #58

noworneverev commented 8 months ago

Wow, really nice! Love the dark mode look, will definitely be using this from now on :D

A couple theme-related things I noticed:

  • the yellow buttons are a bit too bright for dark mode IMO. Could you maybe change them to something like dark:bg-gray-800 dark:text-primary dark:hover:bg-primary dark:hover:text-gray-800? (I think you can just apply those as-is in the scss file)

ok

  • the red "x" marks for privately insured/accompanied are really hard to read in the patient cards, maybe a lighter red would be easier?

ok

  • the theme switcher button sitze really awkwardly - maybe that's just in my browser though? Could you move it (plus maybe "Toggle theme" or something like that) above or below the timetravel button?

Yeah, I move it below the timetravel button now.

grafik

The login screen is always in bright mode, which I guess is a consequence of the way the theme is toggled (really interesting btw, I would probably just have just have set something in localStorage, but this is undoubtedly nicer).

In the beginning, I used localStorage to store the state of the dark mode, as this is usually how other frontend frameworks deal with dark/light mode. However, when I tried using localStorage, every time I switched between pages, the page would flicker back to light mode and then to dark mode(potentially attributable to how Django renders different templates). Consequently, I had to find another way to implement the dark mode.

charludo commented 8 months ago

Awesome! This is ready to merge, just please squash commits beforehand :)