Fix overcrowded rooms - Githubissues

charludo / ycms

Apache License 2.0

0 stars 0 forks source link

Fix overcrowded rooms #112

Open ballerkind opened 7 months ago

ballerkind commented 7 months ago

Describe the Bug

It is possible to put 2 patients with one companion each, i.e., 4 people into a room with only 2 beds.

Steps to Reproduce

Assign two patients without companions into a two bed room.
Click on the room in the ward view and edit both patients to be accompanied by marking the "Accompanied" checkbox in the edit mode.
The result is an overfilled room -> error

Expected Behavior

I cannot set any of these two patients to be accompanied.

Actual Behavior

I can overfill a room.

Additional Information

charludo commented 7 months ago

Related: #82

charludo commented 7 months ago

Some things to consider:

Tabeas's algorithm does no consider accompanying people, so if we enforce this for the timeline view, a lot more of the algorithmically suggested assignments become impossible
what should happen when an accompanying person is added to an already-full room? Show an error message and don't save the changes to the patient stay? Save them, but unassign them?