charludo / ycms

Apache License 2.0
0 stars 0 forks source link

Assignment suggestions using Tabea's PRA solver #115

Closed charludo closed 9 months ago

charludo commented 9 months ago

Short description

The "suggest assignment" button finally works! 🥳 🎉

Proposed changes

Please Note

Installation

Resolved issues

Fixes: #20

SnehaR26 commented 9 months ago

A doubt: I am on the branch automatic-assignment So I installed patient-to-room_assignment in the same directory as ycms. I installed gurobi in the same virtual environment as rest of the project (its called denv). I run ycms and click on suggest assignment but nothing seems to pop up, What am i missing?

charludo commented 9 months ago

A doubt: I am on the branch automatic-assignment So I installed patient-to-room_assignment in the same directory as ycms. I installed gurobi in the same virtual environment as rest of the project (its called denv). I run ycms and click on suggest assignment but nothing seems to pop up, What am i missing?

Please follow the instructions as given:

"next to" means that the two are "siblings". For example,

/home/sneha/ycms/
/home/sneha/patient-to-room_assignment

but not

/home/sneha/ycms/
/home/sneha/ycms/patient-to-room_assignment

(its called denv)

I am really not sure how that works, the install.sh script handles virtual environments in our project, and it will always be located in .venv.

In any case, you need a separate one, as the instructions say.

SnehaR26 commented 9 months ago

"next to" means that the two are "siblings". For example,

/home/sneha/ycms/
/home/sneha/patient-to-room_assignment

but not

/home/sneha/ycms/
/home/sneha/ycms/patient-to-room_assignment

Yup they are siblings.

(its called denv)

I am really not sure how that works, the install.sh script handles virtual environments in our project, and it will always be located in .venv.

In any case, you need a separate one, as the instructions say.

I had created a virtual env denv in the begining where I installed everything in ycms. I followed the instructions also and added venv inside patient-to-room directory. and then I went back to ycms and ran it. clicking on suggest assignment didn't do anything for me. Am I supposed to directly click on that or I check in timetravel for assignments and then it will show

charludo commented 9 months ago

"next to" means that the two are "siblings". For example,

/home/sneha/ycms/
/home/sneha/patient-to-room_assignment

but not

/home/sneha/ycms/
/home/sneha/ycms/patient-to-room_assignment

Yup they are siblings.

(its called denv)

I am really not sure how that works, the install.sh script handles virtual environments in our project, and it will always be located in .venv. In any case, you need a separate one, as the instructions say.

I had created a virtual env denv in the begining where I installed everything in ycms. I followed the instructions also and added venv inside patient-to-room directory. and then I went back to ycms and ran it. clicking on suggest assignment didn't do anything for me. Am I supposed to directly click on that or I check in timetravel for assignments and then it will show

Alright, what's the console output when you click the button? And no, should not matter which one.

charludo commented 9 months ago

Actually, could you please also provide the output of pwd and ls -al from inside the solver directory?

A more direct way for trouble shooting could also be using ./tools/ycms-cli call_solver_api 1, since this is what the ward/timeline views call

SnehaR26 commented 9 months ago

Actually, could you please also provide the output of pwd and ls -al from inside the solver directory?

A more direct way for trouble shooting could also be using ./tools/ycms-cli call_solver_api 1, since this is what the ward/timeline views call

So when I click on the button I get the following output:

image

Console shows this :

image

So the main directory is hosproj under in which both ycms and pra reside.

image

charludo commented 9 months ago

Actually, could you please also provide the output of pwd and ls -al from inside the solver directory? A more direct way for trouble shooting could also be using ./tools/ycms-cli call_solver_api 1, since this is what the ward/timeline views call

So when I click on the button I get the following output:

image

Console shows this :

image

So the main directory is hosproj under in which both ycms and pra reside.

image

From the console error output: looks like you need a (free) license. Interesting. I got one but thought it's activation failed, but apparently not!

Have a look online, the license is pretty easy to get.

SnehaR26 commented 9 months ago

Works for me👌👌. I can see suggested assignments for unassigned patients in the timeline view for past current and future. Do you want to wait till the final data before merging this?

charludo commented 9 months ago

Works for me👌👌. I can see suggested assignments for unassigned patients in the timeline view for past current and future. Do you want to wait till the final data before merging this?

Great! And no, let's merge if you've no change requests.