search

charludo / ycms

Apache License 2.0
0 stars 0 forks source link

Add more tests #121

Closed charludo closed 8 months ago

charludo commented 8 months ago

Short description

This PR brings test coverage up to 80% 🎉

Proposed changes

Side effects

@noworneverev do we still need the /bed-assignments/ view? As far as I can tell, it is currently broken anyways. Do you think the patient detail view introduced in #103 is a sufficient replacement?

Resolved issues

Fixes: #

noworneverev commented 8 months ago

Short description

This PR brings test coverage up to 80% 🎉

Proposed changes

  • add tests to untested views
  • tweak some user permissions

Side effects

  • none I am aware of

@noworneverev do we still need the /bed-assignments/ view? As far as I can tell, it is currently broken anyways. Do you think the patient detail view introduced in #103 is a sufficient replacement?

Resolved issues

Fixes: #

I think there's no need the /bed-assignments/ view. Do you want to just remove them in this PR, or I create another one to remove them?

charludo commented 8 months ago

I think there's no need the /bed-assignments/ view. Do you want to just remove them in this PR, or I create another one to remove them?

Your choice!

noworneverev commented 8 months ago

I think there's no need the /bed-assignments/ view. Do you want to just remove them in this PR, or I create another one to remove them?

Your choice!

I'll create another PR then. I think this PR is good to go after solving the conflict. 😄