charludo / ycms

Apache License 2.0
0 stars 0 forks source link

Multiple small fixes #137

Closed charludo closed 7 months ago

charludo commented 7 months ago

Short description

Multiple small last-minute fixes

Proposed changes

Side effects

Resolved issues

Fixes: n/a

charludo commented 7 months ago

No questions to above, but I have a small question regarding the test data, some patients are born in the future and the age will display "-1". This is not related to final presentation data though, are we going to load only data_final_presentation?

Wait, so the midterm data contains patients that are not yet born?

In any case, good catch, I will limit the age to 0

charludo commented 7 months ago

No questions to above, but I have a small question regarding the test data, some patients are born in the future and the age will display "-1". This is not related to final presentation data though, are we going to load only data_final_presentation?

Wait, so the midterm data contains patients that are not yet born?

In any case, good catch, I will limit the age to 0

done

noworneverev commented 7 months ago

No questions to above, but I have a small question regarding the test data, some patients are born in the future and the age will display "-1". This is not related to final presentation data though, are we going to load only data_final_presentation?

Wait, so the midterm data contains patients that are not yet born?

In any case, good catch, I will limit the age to 0

Yeah, like this one:

  {
    "model": "cms.patient",
    "pk": 175,
    "fields": {
      "creator": 4,
      "created_at": "2024-01-20T13:47:00Z",
      "updated_at": "2024-01-14T07:24:50.995Z",
      "insurance_type": false,
      "first_name": "Sanjiva",
      "last_name": "Kownatzki",
      "gender": "m",
      "date_of_birth": "2024-03-22",
      "_first": "4f6b-836e-1d8d59c525fd",
      "_last": "73ecd750-73e0"
    }
  },