Closed charludo closed 9 months ago
- It would be nice to have a "Cancel" button, maybe next to the "Save" button
Good idea! Done.
- After moving multiple patients between different rooms without saving in between, I lost the overview of what I have changed in total. Maybe we can mark the edited but not yet saved assignments somehow (different background or border color?)
Also very good idea & done.
- The sidebar entry "Ward View" is not marked as "selected" when we are at the timeline view (actually, it is also not marked when the url is "../ward/1/")
Good catch. Since this isn't just timeline-related and this PR is already pretty big, could you open a new issue? (And would you be willing to take it? I have not really looked into how the colors are set in the first place yet)
- Sometimes I cannot do certain assignments. In this screenshot, e.g., I get an error when moving the patient marked yellow to Room 13 and trying to save it.
Oooooof. Yep, I can replicate. BUT the strange thing is: if you first assign P. Bose
to some other room, then assign the small B.
block to where it is shown in the picture, not only does that work, you can then place P. Bose
back to where he originally was!! Why? How??
- Sometimes I cannot do certain assignments. In this screenshot, e.g., I get an error when moving the patient marked yellow to Room 13 and trying to save it.
Oooooof. Yep, I can replicate. BUT the strange thing is: if you first assign
P. Bose
to some other room, then assign the smallB.
block to where it is shown in the picture, not only does that work, you can then placeP. Bose
back to where he originally was!! Why? How??
OK... I found a solution, but I'm not happy about it. Best I can tell, there's something weird going on in the way exclude
and Q
interact. IDK.
Anyways, the specific case you've shown above now works, but it would be really great if you could play around a bit and try to break it again π
Short description
TIMELINE π
Proposed changes
How to review this
onMoving()
andmaxConcurrentBeds()
functions intimeline.ts
. It is likely that an error has occurred somewhere in there.post()
method of theTimelineView
.Resolved issues
Fixes: #59, partially: #119