There's a bug where if a field is both NOT_NULL and a LIST, then it was not getting considered as required. At least, it seems like a bug to me and some other users as well.
Updated the test and it passes.
Not sure about your NPM publishing process, or the way you want handle this wrt Semver? Feels like a minor version bump...but could be considered a patch since it's a bugfix...but it could break some peoples' stuff if they've coded around this bug (as I have in a project that uses this).
Fixes #7
I hope you don't mind this being piled on top of my other branch/changes around the engines and .nvmrc stuff. I can separate out if you like, but if those changes go in, I'll just rebase this branch and things should be fine.
newhouse
commented
3 years ago
There's a bug where if a field is both
NOT_NULLand aLIST, then it was not getting considered asrequired. At least, it seems like a bug to me and some other users as well.Updated the test and it passes.
Not sure about your NPM publishing process, or the way you want handle this wrt Semver? Feels like a
minorversion bump...but could be considered apatchsince it's a bugfix...but it could break some peoples' stuff if they've coded around this bug (as I have in a project that uses this).Fixes #7
I hope you don't mind this being piled on top of my other branch/changes around the
enginesand.nvmrcstuff. I can separate out if you like, but if those changes go in, I'll just rebase this branch and things should be fine.