Feed and play endpoints

[samikshakarimbil]

Finished the feed and play endpoints :)

[charm-13]

overall, looks good. here's a couple of notes:

• in feed, a COALESE could be added to the "affinity" execute to avoid the if on 99. i.e. "SELECT COALESCE(affinity, 0) FROM ..." then remaining_affinity = 100 - affinity["affinity"]
• ^ same for play

[thuang-28]

looks good for the most part! though I have some suggestions for readability/conciseness

Feed Creature Endpoint

• I noticed that treat_sku is defined the feed endpoint function's parameters, but the router URL itself still has {treat_id} as a parameter. I don't think it will work if they don't match
• I think it would make more sense to get both stats and affinity (using an additional JOIN) in one query, instead of retrieving them separately. I have similar logic written for get_creatures() right now. Combined with @charm-13's suggestion for affinity, it'd be like this:

   SELECT happiness, hunger, fav_treat, hated_treat, COALESCE(user_creature_connection.affinity, 0) AS affinity
   FROM creatures 
   JOIN creature_types ON creatures.type = creature_types.type AND creatures.id = :creature
   LEFT JOIN user_creature_connection ON creatures.id = user_creature_connection.creature_id AND user_id = :user_id

  ^ this should work even when user has no established connection with the creature

• The calculations for remaining stats (remaining_hunger, remaining_happiness, remaining_affinity) could be done within the initial SQL query instead of being processed by Python. I think it would improve readability, especially since you reference stats["happiness"] and stats["hunger"] only once in feed_creatures().
  • For example, instead of SELECT happiness..., you would write SELECT (100 - happiness) AS remaining_happiness..., and reference it later on as stats['remaining_happiness']

Play With Creature Endpoint

• Same thing as I said with feed_creatures(), happiness and affinity could be retrieved at once.