search

charm-13 / petcafe

https://cute-creature-cafe.onrender.com
0 stars 0 forks source link

get_creature_stats() and adopt_creature() endpoints #4

Closed thuang-28 closed 1 week ago

thuang-28 commented 1 week ago

implemented get_creature_stats() and adopt_creature() endpoints in creatures.py

charm-13 commented 1 week ago

Looks good! However, one thing to keep in mind when merging is that in main feed_creature() takes in treat_sku, but on this branch it takes in treat_id, which can mess some things up if it doesn't take main's changes.

samikshakarimbil commented 1 week ago

Looks pretty good, just one note: In line 22 (in the sql query for get_creatures()) I dont think "COALESCE(user_creature_connection.is_adopted, false) AS status" is necessary because is_adopted's default value is false. Otherwise, this looks good to merge!