charmainehly / pe

0 stars 0 forks source link

Error message may not be specific enough #4

Open charmainehly opened 2 years ago

charmainehly commented 2 years ago

Error message states that tag should be alphanumeric, but does not really point to the error that the spacing is not allowed in the tag.

image.png

nus-pe-bot commented 2 years ago

Team's Response

alphanumeric = alphabets or numbers only.

Space is not an alphabet nor is it a number.

According to CS2103T website: https://nus-cs2103-ay2122s2.github.io/website/admin/tp-pe.html#:~:text=Specificity%20of%20error%20message%3A%20Error%20messages%20can%20be%20correct%20but%20not%20specific%20enough%20(e.g.%2C%20it%20says%20the%20input%20is%20%27invalid%27%20without%20giving%20the%20reason%2C%20or%20gives%20too%20many%20possible%20reasons%20without%20pointing%20out%20the%20specific%20reason).%20These%20cases%20can%20be%20considered%20type.FeatureFlaw.

Specificity of error message: Error messages can be correct but not specific enough (e.g., it says the input is 'invalid' without giving the reason, or gives too many possible reasons without pointing out the specific reason). These cases can be considered type.FeatureFlaw.

The reason is generic, but it is not overly general in stating too many possible reasons. In fact, it states that the tags must be alphabets or numbers only, which is already telling users that:

  1. Issue arose from tags
  2. Issue arose from using things that are not alphanumeric.

Rejected

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]