search

charmbracelet / bubbles

TUI components for Bubble Tea 🫧
MIT License
5.56k stars 264 forks source link

KeySpace KeyType is not handled #144

Closed rosmanov closed 2 years ago

rosmanov commented 2 years ago

bubbletea has recently changed the KeyType for the space character.

As a result, in particular, nothing happens when the user enters space in the textinput component.

We need to add a case tea.KeySpace: somewhere around these lines.

bubbles revision is 292a1dd7ba97b1dc96a12d5ba50301cc731ef37f (current master)

meowgorithm commented 2 years ago

Hi! @bashbunni just fixed this in https://github.com/charmbracelet/bubbletea/pull/289. It will be available in the next release of Bubble Tea. If you need the functionality immediately you can pin to master.

Sorry for the confusion!

meowgorithm commented 2 years ago

Apologies, I completely misread this one. This is a very good catch. We'll correct this one shortly. Thank you for filing this.

bashbunni commented 2 years ago

@meowgorithm let me know if this is still a wip but saw it was merged

meowgorithm commented 2 years ago

Merged in master on the Bubble Tea side, so we do need to make this change after all. Let’s get this one in a PR and queue it up to be merged right after the next Bubble Tea release.

meowgorithm commented 2 years ago

This is now fixed for both the present and the upcoming Bubble Tea versions.