search

charmbracelet / bubbles

TUI components for Bubble Tea 🫧
MIT License
5.52k stars 265 forks source link

fix(textarea): Fix end of buffer character #491

Closed mikelorant closed 8 months ago

mikelorant commented 8 months ago

The end of buffer character was not being rendered when line numbers were not enabled.

When the new test tables unit tests were created this issue was identified however to limit the scope of those changes to just creating unit tests, this regression was maintained.

This change fixes this issue and updates the tests to the intended result.

maaslalani commented 8 months ago

Awesome, thanks @mikelorant!

Going to merge this since it is the way it works in vim but just as a heads up may revert this one in the future depending on what users expect.

mikelorant commented 8 months ago

Totally understand if you want to revert functionality.

My personal view is that end of buffer character should be set to a space character which would make it invisible. The developer should have to set it to make it available.

maaslalani commented 8 months ago

Sounds good, I agree on the setting to space character as well (for now)! Thanks for all the awesome work @mikelorant!