chore: switch to x/ansi for text manipulation

charmbracelet / bubbles

TUI components for Bubble Tea 🫧

MIT License

5.24k stars 247 forks source link

chore: switch to x/ansi for text manipulation #505

Closed aymanbagabas closed 2 months ago

aymanbagabas commented 4 months ago

Need to be consistent with Lipgloss and https://github.com/charmbracelet/lipgloss/pull/279

aymanbagabas commented 4 months ago

P.S. @mikelorant I haven't tested any of the bubbles yet

mikelorant commented 4 months ago

Looks like we need to check:

List
Progress

mikelorant commented 4 months ago

@aymanbagabas Have confirmed that both list and progress are working correctly with the changes (based on modified examples that are part of Bubble Tea). Unit tests are also passing successfully.

I believe this is safe to merge.

mikelorant commented 3 months ago

@meowgorithm @aymanbagabas Can we look at getting this one merged? This should mean we are free of the legacy string width functions in all the important places.