charmbracelet / bubbles

TUI components for Bubble Tea 🫧
MIT License
5.24k stars 247 forks source link

JoinHorizontal should use top/bottom not left/right #553

Closed shaunco closed 1 week ago

shaunco commented 1 month ago

These JoinHorizontal calls should use lipgloss.Top rather than lipgloss.Left:

aditipatelpro commented 1 month ago

@shaunco , I would love to contribute to this project and this issue seems interesting to start with. I would love to start working on this if you are open for contributions.

shaunco commented 1 month ago

@aditipatelpro I am just a user of charmbracelet, not a maintainer but it appears that the project accepts plenty of outside PRs.

aditipatelpro commented 3 weeks ago

Thank you @shaunco.

@muesli @meowgorithm @aymanbagabas, I am interested in contributing to this project and would love to start working on it if you are open to it.

bashbunni commented 1 week ago

@aditipatelpro if you would like to contribute a fix for this, please do! We appreciate all of the contributions we get :)