charmbracelet / bubbles

TUI components for Bubble Tea 🫧
MIT License
5.24k stars 247 forks source link

fix(help): wrong full help sep rendering #554

Open luevano opened 1 month ago

luevano commented 1 month ago

No matter the available horizontal space, sometimes the separator for the full help is not rendered. For example:

image image

The issue is that the check if a separator needs to be rendered is done on group (the column) and not groups (the total columns). With this fixed:

image image

However, when there is enough space for the separator but not the column itself it renders the separator at the end: image

This PR fixes these 2 issues and matches the behavior of the short help (adding a tail if needed/possible, rendering the separator inline, etc.). Behavior now: image image image

bashbunni commented 2 days ago

We should add a test for this