search

charmbracelet / bubbles

TUI components for Bubble Tea 🫧
MIT License
5.37k stars 252 forks source link

fix(help): use length of groups, not items within a group, for separator behavior #569

Closed blvrd closed 1 month ago

blvrd commented 1 month ago

Fixes #568

In the demos below, I'm using xxxxxx as the FullSeparator to clearly demonstrate the behavior before/after.

Behavior before this fix ![before fix](https://github.com/user-attachments/assets/b0a88c27-b46b-4bdc-9e4a-1b103aead19a)
Behavior after this fix: ![after_fix](https://github.com/user-attachments/assets/cbc42bba-f3e4-4e2f-93e3-c3dda94c721e)
luevano commented 1 month ago

I already had opened a PR for this: #554

blvrd commented 1 month ago

I already had opened a PR for this: #554

Oops! Didn't look closely enough. Looks like your solution is more comprehensive. Closing in favor of #554.