search

charmbracelet / freeze

Generate images of code and terminal output 📸
MIT License
3.24k stars 55 forks source link

feat: include command config option #81

Open isabelroses opened 5 months ago

isabelroses commented 5 months ago

closes https://github.com/charmbracelet/freeze/issues/44

Delta456 commented 5 months ago

Should also close https://github.com/charmbracelet/freeze/issues/76

isabelroses commented 5 months ago
Example outputs

![ex1](https://github.com/charmbracelet/freeze/assets/71222764/415da93e-e849-44a0-8ecb-dfaffa2e2b43) ![ex2](https://github.com/charmbracelet/freeze/assets/71222764/6f9aa2b4-3772-4dcd-abee-77c8686d30f2)

maaslalani commented 5 months ago

Hey @isabelroses, this is an awesome PR:

I think it would benefit from a few changes:

  1. Let's prefix the option with --execute. so it's logically grouped with the execute functionality.

  2. I think it can be on by default, what do you think? i.e. opt-out --execute.command=false (maybe --execute.show-command?)

  3. Change the prompt to > to match VHS, we use:

PS1=\\[\\e[38;2;90;86;224m\\]> \\[\\e[0m\\]
isabelroses commented 5 months ago

So after making the suggested changes the outputs have changed from before, somehow the eza's output has ended up shifted out2 test

isabelroses commented 5 months ago

So after making the suggested changes the outputs have changed from before, somehow the eza's output has ended up

Realised this might be because since the start of this PR I installed libsvg.

maaslalani commented 5 months ago

freeze

maaslalani commented 5 months ago

I believe it could be because of the font, since it's not a monospace font, it looks like.

isabelroses commented 5 months ago

I believe it could be because of the font, since it's not a monospace font, it looks like.

Ahh good call this is on WSL.

4zv4l commented 4 months ago

Hi, any update on this ? Do we know when it would be merged ?