search

charmbracelet / glamour

Stylesheet-based markdown rendering for your CLI apps 💇🏻‍♀️
MIT License
2.46k stars 180 forks source link

Link URLs not displayed when link is inside emphasis #187

Open gardenappl opened 3 years ago

gardenappl commented 3 years ago

Not sure whether this is an issue with glow or with glamour, sorry if I got this wrong.

When parsing a file with the following line:

**Hello [world](https://example.com), testing**

I expect output similar to:

Hello world https://example.com, testing

(where "world" has a different color)

What I get instead is just:

Hello world, testing

(where "world" is the same color as the rest of the line)

Same issue happens with italics. Note that Github does support links with emphasis:

Hello world, testing

I'm using glow 1.2.1 (more specifically, the glow-bin package from AUR)

anshul-march commented 3 years ago

Yeah, this issue still persists! :/

muesli commented 3 years ago

Sorry about that, but it's a slightly more involved change in the renderer. We're working on a bit of a refactor to improve handling nested elements.