charmbracelet / glamour

Stylesheet-based markdown rendering for your CLI apps 💇🏻‍♀️
MIT License
2.48k stars 180 forks source link

Some rendering issues #46

Closed jarun closed 4 years ago

jarun commented 4 years ago

I was viewing a README with glow. Noticed the following issues:

From the Features section (https://github.com/jarun/nnn/blob/master/README.md#features):

  • Familiar shortcuts (arrows,                                                                   
    ~                                                                                               
    ,                                                                                               
    -                                                                                               
    ,                                                                                               
    @                                                                                               
    ), quick reference                                                                              
    • CD on quit (easy shell integration)

Also the table of deps (https://github.com/jarun/nnn/blob/master/README.md#utility-dependencies) looks broken:

  $VISUAL$EDITOR$PAGER$SHELL            DEPENDENCY           │ INSTALLATION │           OPERATION   
  ─────────────────────────────────┼──────────────┼─────────────────────────────────                
    xdg-open (Linux), open(1)      │ base         │ desktop opener                                  
    (macOS), cygstart (Cygwin)     │              │                                                 
    file, coreutils (cp, mv, rm),  │ base         │ file type, copy, move and                       
    xargs                          │              │ remove                                          
    tar, (un)zip [atool/bsdtar for │ base         │ create, list, extract tar,                      
    more formats]                  │              │ gzip, bzip2, zip                                
    archivemount, fusermount(3)    │ optional     │ mount, unmount archives                         
    sshfs, rclone, fusermount(3)   │ optional     │ mount, unmount remotes                          
    trash-cli                      │ optional     │ trash files (default action:                    
                                   │              │ rm)                                             
    vlock (Linux), bashlock        │ optional     │ terminal locker (fallback:                      
    (macOS), lock(1) (BSD)         │              │ cmatrix)                                        
    advcpmv (Linux) (integration)  │ optional     │ copy, move progress                             
    $VISUAL (else $EDITOR),        │ optional     │ fallback vi, less, sh                           
    $PAGER, $SHELL                 │              │                                                 
muesli commented 4 years ago

Thanks @jarun, I'll try to resolve these issues asap!

jarun commented 4 years ago

Awesome!

muesli commented 4 years ago

Fixed by de9bf21.

jarun commented 4 years ago

Thank you!

jarun commented 4 years ago

The table is fixed... but I still see:

    • Familiar shortcuts (arrows,                                                                   
    ~                                                                                               
    ,                                                                                               
    -                                                                                               
    ,                                                                                               
    @                                                                                               
    ), quick reference
muesli commented 4 years ago

I've just released glow 0.1.5, which depends on the latest fixes. Can you make sure to try it out with that release? Thank you!

jarun commented 4 years ago

Works like a charm!

jarun commented 4 years ago

Hi, just wanted to let you know that glow is now the default Markdown viewer in nuke, the CLI opener for nnn: https://github.com/jarun/nnn/commit/d224016011c4500074c29609dbc157fe7cedac09.

muesli commented 4 years ago

That's fantastic, thanks @jarun!