search

charmbracelet / glow

Render markdown on the CLI, with pizzazz! 💅🏻
MIT License
16.38k stars 360 forks source link

Make --all configurable globally #651

Closed skatkov closed 1 month ago

skatkov commented 1 month ago

fixes #650

bashbunni commented 1 month ago

Hey, I saw your issue and this change totally makes sense. We should probably mention this feature in the config section of the README. We should also add this field to the default config as well. Probably defaulting to all? I think that not being able to view files you would expect is more confusing than seeing these files and figuring out how to hide them

skatkov commented 1 month ago

@bashbunni that's awesome suggestion!

bashbunni commented 1 month ago

I just tweaked some things here - the all field was redundant as the showAllFiles field was already handling this behaviour. I added a default value of true to both the configuration file, and to the field itself in case it's unset anywhere. Tested that it works with both true and false values both in the config file and the args :)

bashbunni commented 1 month ago

Let me know if it behaves as you'd expect, if so I can merge it :)

skatkov commented 1 month ago

@bashbunni tested this locally, and it does work as expected!