search

charmbracelet / gum

A tool for glamorous shell scripts 🎀
MIT License
18.16k stars 344 forks source link

gum spin to support Fira Code spinner codepoints. #234

Open christianparpart opened 1 year ago

christianparpart commented 1 year ago

Is your feature request related to a problem? Please describe. There are various spinning box ways in the terminal. Fira Code tries to spice that up a bit by providing actual spinning glyphs.

Describe the solution you'd like I would like gum spin to make use of that and provide support for it via gum spin --spinner=fira with fira denoting that the Fira Code introduce spinning codepoints will be used (see link below).

Describe alternatives you've considered ASCII arts

Additional context See https://github.com/tonsky/FiraCode/releases/tag/6 for the release page, description & demo

maaslalani commented 1 year ago

Hey @christianparpart, thanks for opening up this issue.

I believe that this would be more appropriate for Bubbles since all the spinners we use are directly from there.

That being said, we typically avoid adding spinners that require specific fonts (at least for defaults) to be installed as using them wouldn't work on other's machines. See https://github.com/charmbracelet/bubbles/pull/209

I think a good solution would perhaps be to allow custom glyphs for gum to customize the spinner.

gum spin --glyphs a,b,c,d,e,f,...
christianparpart commented 1 year ago

That sounds good, but be sure to support U+XX...X notation.

And while being at it, their are certain just perceived characters (aka. grapheme clusters) that take up multiple codepoints but end up forming a single character. Be sure to support that and it would allow really cool spinners . If you fear spacing (cursor positioning) issues, use DECSC and DECRC to save/restore the cursor.

On Fri, Nov 11, 2022, 6:57 PM Maas Lalani @.***> wrote:

Hey @christianparpart https://github.com/christianparpart, thanks for opening up this issue.

I believe that this would be more appropriate for Bubbles https://github.com/charmbracelet/bubbles since all the spinners we use are directly from there.

That being said, we typically avoid adding spinners that require specific fonts (at least for defaults) to be installed as using them wouldn't work on other's machines. See charmbracelet/bubbles#209 https://github.com/charmbracelet/bubbles/pull/209

I think a good solution would perhaps be to allow custom glyphs for gum to customize the spinner.

gum spin --glyphs a,b,c,d,e,f,...

— Reply to this email directly, view it on GitHub https://github.com/charmbracelet/gum/issues/234#issuecomment-1312003555, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN3O7R3SRHCLXSAVG7OXDWH2CJ3ANCNFSM6AAAAAAR5Q3ZYM . You are receiving this because you were mentioned.Message ID: @.***>