gum choose v0.14.0: timeout no longer working - Githubissues

charmbracelet / gum

A tool for glamorous shell scripts 🎀

MIT License

17.94k stars 339 forks source link

gum choose v0.14.0: timeout no longer working #565

Closed daviehh closed 2 months ago

daviehh commented 5 months ago

Describe the bug gum choose --selected="foo" --timeout=3s "a" "b" "foo" "d" timeout no longer working

To Reproduce Steps to reproduce the behavior:

gum choose --selected="foo" --timeout=3s "a" "b" "foo" "d"
No progress

Expected behavior timeout after 3s

Desktop (please complete the following information):

OS: macos 14.4.1

Incidentally

https://github.com/charmbracelet/gum/blob/4222e59c25dbd25423285e5d088b8c66d758c87b/choose/options.go#L27

typo for GUM_CCHOOSE_TIMEOUT?

MrOggy85 commented 4 months ago

I think this change broke the timeout: https://github.com/charmbracelet/gum/pull/522 It seems like the timeout functionality was not implemented when using the new framework @maaslalani