charmbracelet / gum

A tool for glamorous shell scripts 🎀
MIT License
17.68k stars 333 forks source link

`gum choose --item.foreground` has no effect #614

Closed JacobKochems closed 1 month ago

JacobKochems commented 1 month ago

Describe the bug gum choose --item.foreground has no effect. I tried several color codes but none had any effect on the colorization of the list items.

To Reproduce Steps to reproduce the behavior:

  1. Type gum choose 1 2 3 into a terminal emulator with color support
  2. Type gum choose 1 2 3 --item.foreground 12 into a terminal emulator with color support
  3. Notice that there is no difference in the colorization of the non-selected list items.

Expected behavior The non-selected list items should be displayed in the specified color (Blue (System)).

Screenshots Kitty (theme: Gruvbox Material Dark Soft) selected foreground item foreground item foreground_subshell

Kitty (theme: Github Light High Contrast) light_item foreground light_item foreground_subshell

Desktop (please complete the following information):

Additional context As one can see from the last screenshot gum choose behaves differently with respect to styling if called from within a subshell, which is especially unfortunate if one really needs to use a light theme (because of lighting conditions), in which case the list items are very hard to read.

meowgorithm commented 1 month ago

Just a note that this is fixed in huh and will hit gum after we do a point release and bump the dependency.

JacobKochems commented 1 month ago

Thanks for the information. I guess we leave this issue open until the version bump and then close it?

meowgorithm commented 1 month ago

Yeah. Well do it soon to fix a few issues.

meowgorithm commented 1 month ago

This is fixed in main and will be available in the next release.

meowgorithm commented 1 month ago

Released! Find this in Gum v0.14.2.