fix(multiselect): check if is filterable before enable filtering

charmbracelet / huh

Build terminal forms and prompts 🤷🏻‍♀️

MIT License

4.18k stars 113 forks source link

fix(multiselect): check if is filterable before enable filtering #254

Closed MikaelFangel closed 1 month ago

MikaelFangel commented 4 months ago

Fixes #251

Changes:

Check if the multi select is filterable before changing the state to filtering.
Update the test accordingly to the change

maaslalani commented 4 months ago

We should actually simply disable the keybinding so it doesn't show up in the help, disabling it will also prevent this switch from activating.

MikaelFangel commented 4 months ago

That makes perfect sense. I've implemented the change now (:

MikaelFangel commented 4 months ago

@maaslalani - I noticed by this it will default to disable filterable and thus making this a breaking change. Should we add a line enabling filterable per default?

skatkov commented 4 months ago

Awesome fix, looking forward for this to get merged ;-)

caarlos0 commented 2 months ago

@maaslalani - I noticed by this it will default to disable filterable and thus making this a breaking change. Should we add a line enabling filterable per default?

i think so yeah... can probably do it in New

caarlos0 commented 2 months ago

done in https://github.com/charmbracelet/huh/pull/335