Closed prithvijj closed 1 month ago
Hey @prithvijj thank you so much for your work on this! I couldn't make changes to this PR for some reason, so had to create a new one to update the godoc for the function you introduced. It's now merged to main
and we're planning on adding additional tests for this in a follow up PR :) Thanks again!! If you're on the Discord, please let us know your username so we can add you as a contributor over there too 🎊
Closing as these changes were added in #427 instead
Hey @prithvijj thank you so much for your work on this! I couldn't make changes to this PR for some reason, so had to create a new one to update the godoc for the function you introduced. It's now merged to
main
and we're planning on adding additional tests for this in a follow up PR :) Thanks again!! If you're on the Discord, please let us know your username so we can add you as a contributor over there too 🎊
Thanks for reviewing and merging it @bashbunni ! Weird that changes couldn't be made to the PR, guess I can check my github stuff's configured correctly
Yepp, already saw that I got the contributor
tag there too! Appreciate it a lot !
Changes
Testing
Made some changes within
examples/git/main.go
to test out these changesBefore: Confirm buttons would appear in the center of the confirm view field
(Long Title, with buttons aligned in the center)
(Short title, with buttons aligned in the center)
After: adding
withButtonAlignment(lipgloss.Left)
, confirm buttons appears on the left of the confirm view field(Long Title, with buttons aligned in the left)
(Short title, with buttons aligned in the left)
Other Notes