search

charmbracelet / pop

Send emails from your terminal 📬
MIT License
2.28k stars 42 forks source link

status code issue for the 0.2.0 release #21

Closed chenrui333 closed 11 months ago

chenrui333 commented 11 months ago

Describe the bug

Looks like for the 0.2.0 release, the status code for missing RESEND_API_KEY is wrong, instead of reporting 1, it reports 0

relates to https://github.com/Homebrew/homebrew-core/pull/138222

To Reproduce Steps to reproduce the behavior:

  1. Install latest pop 0.2.0
  2. pop --body 'hi' --subject 'Hello'
  3. check the status code
maaslalani commented 11 months ago

Thanks I will fix this now

maaslalani commented 11 months ago

Fixed: https://github.com/charmbracelet/pop/commit/65b34a366addd90a9d4da32ac8e5d22268ec16bd

chenrui333 commented 11 months ago

thanks for the quick turnaround, let me try the patch.

chenrui333 commented 11 months ago

works for me, thanks for the quick fix. 🙏