search

charmbracelet / pop

Send emails from your terminal 📬
MIT License
2.36k stars 49 forks source link

SMTP username takes priority over from argument #24

Closed Birdie0 closed 1 year ago

Birdie0 commented 1 year ago

Describe the bug When having set both 'SMTP username' and 'from address' (through ENV variables or arguments) username takes priority.

To Reproduce Steps to reproduce the behavior:

  1. Run command: pop --smtp.host localhost --smtp.port 25 --smtp.username test --smtp.password hunter2 --from test@example.com

Expected behavior From should be prefilled with test@example.com, instead there's test as value of --smtp.username

Screenshots image

Desktop:

Additional context Add any other context about the problem here.

maaslalani commented 1 year ago

You're absolutely correct! I will fix this thank you!

angelnext commented 1 year ago

Has there been any progress?

maaslalani commented 1 year ago

Fixed by #36, thanks for the ping @angelnext!