search

charmbracelet / pop

Send emails from your terminal 📬
MIT License
2.28k stars 42 forks source link

fix: handle both resend and smtp set up together #28

Closed caarlos0 closed 11 months ago

caarlos0 commented 11 months ago

closes #27

maaslalani commented 11 months ago

I wonder if we need this, I don't think we have to error out if we can still send the email with resend. What are your thoughts?

caarlos0 commented 11 months ago

I believe that setting up both smtp and resend will usually be an user error, so I think its best to warn them instead of potentially throwing weird resend errors.

Anyway, its your call, I second whatever you decide :)

maaslalani commented 11 months ago

Sounds good! After thinking it over a bit I can see how this error could be useful so that it is explicit which delivery method we are using.