charmbracelet / soft-serve

The mighty, self-hostable Git server for the command line🍦
MIT License
5.16k stars 127 forks source link

Blocking anon users from accesing server with allow-keyless set to True #524

Closed sirdrops closed 3 weeks ago

sirdrops commented 3 months ago

Describe the bug After setting allow-keyless to true, and anon-access to no-access I assumed I could still use http/git connection while making unauthorized users unable to access the server over ssh yet I can still access the server,browse and clones repos with anon-user. Am I misunderstanding how both of those settings work?

To Reproduce Set allow-keyless true Set anon-access no-access ssh -p 23231 - from anon user

Expected behavior Able to use http/git connections with tokens while disabling anon users from accessing server altogether

Hosted on linux 24.04, soft server installed from repository

n1yn commented 3 weeks ago

I also experience the same issue on my instance

aymanbagabas commented 3 weeks ago

Thank you for reporting this issue @sirdrops & @n1yn! This is now fixed in main and will be released in v0.7.7.