fix: update position constant in `JoinHorizontal`

charmbracelet / soft-serve

The mighty, self-hostable Git server for the command line🍦

MIT License

5.34k stars 135 forks source link

fix: update position constant in `JoinHorizontal` #552

Closed aditipatelpro closed 1 month ago

aditipatelpro commented 3 months ago

This PR fixes: https://github.com/charmbracelet/soft-serve/issues/540

Ideally, JoinHorizontal should expect Top, Bottom, or Center positions. This PR fixes the cases where the Left position constant was used instead of Top.

I found the same thing while looking for JoinVertical calls. So I have updated position constants in JoinVertical calls as well.

aymanbagabas commented 1 month ago

Thank you @aditipatelpro!