search

charmbracelet / vhs

Your CLI home video recorder 📼
MIT License
14.98k stars 247 forks source link

Add Page Up and Page Down keys #203

Closed mikelorant closed 1 year ago

mikelorant commented 1 year ago

It would be beneficial to have the page up and page down keys as commands. This would be especially useful with the Bubbles list component which uses these keys to move pages.

Implemented with PR #202.

mikelorant commented 1 year ago

@maaslalani Any chance we can get the PR related to this issue merged?

Please take a look at my other issues for keys, Ive got implementations for them down already, just need some guidance before I submits PRs.

maaslalani commented 1 year ago

@mikelorant The PR looks great! I will merge tonight!

mikelorant commented 1 year ago

Thanks. The other 2 PRs require a fair bit more work. Ive got branches for both but Im not sure if my approach is right. Just let me how you'd like them implemented and I will do it the way you'd like.

maaslalani commented 1 year ago

Hey @mikelorant, the Alt + Ctrl modifiers should work well in combination with each other, see: https://github.com/charmbracelet/vhs/issues/33

maaslalani commented 1 year ago

The implementation will look something like:

Ctrl+Shift+O
Ctrl+Alt+L
Ctrl+Alt+Shift+P
Ctrl+Shift+Alt+C

Such that the modifiers can be combined (ideally in any order, but ordered is fine as well).

mikelorant commented 1 year ago

No problem. Knowing how alt works should make this much easier to implement.

maaslalani commented 1 year ago

Thanks again for the awesome work on this @mikelorant!