charmbracelet / vhs

Your CLI home video recorder 📼
MIT License
14.34k stars 241 forks source link

Rendering braille characters without the empty dots #322

Closed joshka closed 1 month ago

joshka commented 1 year ago

Describe the bug My terminal (iterm2) renders braille characters without the empty dots in the various fonts I have installed, but try as I might I can't seem to get vhs to render them the same:

Braille.gif

Setup Please complete the following information along with version numbers, if applicable. macOS / zsh / iterm

To Reproduce Steps to reproduce the behavior:

Output braille.gif
Set Width 400
Set Height 300
Set Shell zsh
Type "echo ⢕"
Sleep 2s
Enter
Sleep 2s

Also attempted with Set FontFamily FiraCode Nerd Font and a bunch of other fonts including DejaVu

https://www.fileformat.info/info/unicode/char/2895/fontsupport.htm shows font support

Expected behavior

Empty dots are empty:

image

Context We use braille characters to render dot images in TUIs (specifically ratatui)

maaslalani commented 1 year ago

Hey thanks for this issue! I have added a fallback for "Apple Symbols" which appears to me to fix this issue on macs. I will add the Linux fix shortly as well.

joshka commented 1 year ago

Thanks! This should make rendering screencasts of ratatui just that little bit easier.

hasezoey commented 10 months ago

at least for me on vhs 0.6.0 and Linux (Manjaro 23.0.0) and KDE Konsole, it renders braille correctly:

(using the vhs code from https://github.com/charmbracelet/vhs/issues/322#issue-1746812179) braille