Open knpwrs opened 2 years ago
Thanks for reporting this, looks like the default bash message that Apple prints when using bash. I will take a look!
@knpwrs, can you add the following to your .bashrc
?
export BASH_SILENCE_DEPRECATION_WARNING=1
If this works for you, I'll add it by default in VHS so that people don't have to add it manually.
That doesn't appear to suppress the message. Now it lasts for 23 frames.
This is frame 22:
And this is frame 23:
I am experiencing something similar on Windows. @knpwrs How are you looking at the individual frames? Using this tape:
# Where should we write the GIF?
Output demo.gif
# Set up a 1200x600 terminal with 46px font.
# Set FontSize 46
Set Width 1200
Set Height 600
# Type a command in the terminal.
Type "npx -y git-truck"
# Pause for dramatic effect...
Sleep 500ms
# Run the command by pressing enter.
Enter
# Admire the output for a bit.
Sleep 30s
As a temporary measure, until we get this fixed, I believe this adding a Hide
+ Sleep
(place after output and settings) should skip the frames for you at the beginning.
Hide Sleep 1s Show
# Start ...
I think I might have improved that in #55
How are you looking at the individual frames?
When you open .gif
files in Preview.app
on macOS all of the individual frames show up in the left-hand thumbnail view.
You can also do Set Output frames/
(trailing slash is important I think) and vhs will output all frames as png in a frames
folder.
I got the same issue on a Mac, this is the first frame of the example tape:
I'm getting extra frames too, with zsh
on Macos:
Same problem here; no matter what I do or which shell I use, these vhs
-specific shell commands appear at the start of the video (mac OS Monterey).
https://user-images.githubusercontent.com/552829/205569182-0183a7a7-63e8-4c43-8330-a0409749c314.mp4
My current attempt:
Output media/demo.mp4
Hide
Require npx
#Set Shell bash
Set FontSize 17
Set Width 1200
Set Height 600
Set Padding 24
#Set LoopOffset 75%
Show
Sleep 1s
Type "npx tsx src/example.ts"
Sleep 500ms
Enter
Show
Sleep 5s
Sleep 5s
I know this is from a while back, but I just tried it on my Mac after installing vhs with brew
and it seems to be fixed. Is anyone still having this issue?
After commenting out my workaround ( lines 16-19) I just retried it with demo.tape and still saw the extraneous text I mentioned in above comments.
$ vhs --version
vhs version v0.2.0 (6f7cc81)
Who knows, this might have something to do with my zsh config?
@bbkane that might be it, yes, if so, this should help: https://github.com/charmbracelet/vhs/pull/212
I can retry after that's merged, thanks @caarlos0 ! If I get time, I'll also try with an unconfigured zsh and see what happens
sounds good, merged @bbkane
I'm actually seeing this exact message in a commit for vhs Setup()
func
https://github.com/charmbracelet/vhs/commit/f21a959d2b5c6687e290c317e8f22cbbbced12b5. Carlos probably fixed that with his PR
@bashbunni yeah that cmd runs before right after starting zsh... my guess is that the user/system config is taking a bit too long to load, and then the clear
takes a little too long to exec, and we see those frames.
If that's the issue, my PR should fix or at least help with that... it prevents loading user & system configs, and also uses another way to set prompt.
I've just installed it from brew and the issue is still present. Though the workaround with Hide Sleep 5s Show
works
the fixes I made are not released yet I think...
I attempted to put together a gif to demo my crate, woodo: https://github.com/knpwrs/woodo
Here is my script:
Here is the output gif:
The gif starts out with 11 frames, ending with:
Before transitioning to: