charmbracelet / vhs

Your CLI home video recorder 📼
MIT License
14.97k stars 248 forks source link

Output frames don't do anything #456

Open Disonantemus opened 6 months ago

Disonantemus commented 6 months ago

Describe the bug

If I try to get frames output, do nothing at all.

I didn't find any verbose switch to get more information. I needed this because, video output (mp4, webm, gif) doesn't have any control, and I wanted to fine tune encoding parameters.

Setup

VHS: version v0.7.1 (537d03a)
OS: Arch Linux x86_64
Kernel: 6.1.52-1-lts
Shell: bash 5.2.26
Terminal: tmux
Terminal Emulator: st | xterm

To Reproduce

$ mkdir test && cd test && wget -q https://raw.githubusercontent.com/charmbracelet/vhs/main/examples/neofetch/neofetch.tape

$ vhs neofetch.tape
File: neofetch.tape
Host your GIF on vhs.charm.sh: vhs publish <file>.gif
Output .gif examples/neofetch/neofetch.gif
Output .mp4 examples/neofetch/neofetch.mp4
Output .webm examples/neofetch/neofetch.webm
Output .png examples/neofetch/frames/
Set TypingSpeed 75ms
Set FontSize 22
Set Width 1300
Set Height 650
Type neofetch
Sleep 500ms
Enter 1
Sleep 2s
Type Welcome to VHS!
Sleep 1s
Space 1
Type A tool for generating terminal GIFs from code.
Sleep 5s
Creating examples/neofetch/neofetch.gif...
Creating examples/neofetch/neofetch.mp4...
Creating examples/neofetch/neofetch.webm...

$ cd examples/neofetch/ && ls -1
neofetch.gif
neofetch.mp4
neofetch.webm

Source Code Your main example at README.md

Expected behavior Should create frames folder and png files inside.

Screenshots Exactly the same as section "To Reproduce".

Additional context No.

jakehamilton commented 4 months ago

Can confirm this is also broken for me when testing on versions 0.6.0 and 0.7.1. Specifying Output frames/ will not output anything.