search

charmed-hpc / hpc-libs

A collection of charm libraries for authoring HPC charms 📖🖋️
https://charmhub.io/hpc-libs
Apache License 2.0
0 stars 3 forks source link

feat: abstract around base package manager #22

Closed jedel1043 closed 1 month ago

jedel1043 commented 2 months ago

This PR abstracts around the base package manager used.

The objective of this is to enable switching between snap packages and deb packages in a more composable way.

NucciTheBoss commented 2 months ago

I think we're on the right path here with enabling support for Slurm in both snap and deb form, but I'm wondering where we can "duplicate" things between package formats such that we don't need to have as much abstraction happening in the background to manipulate things like the munge key file and Slurm configuration in the background.

Re. the Slurm configuration, we can just manipulate that with slurmutils. For the munge key, we need to enable support for changing the key file location in mungectl.

jedel1043 commented 2 months ago

@NucciTheBoss Yeah, using mungectl and slurmutils on both snap and deb mode would be nice. In the meantime, I think we can just push the current abstractions and see if we can unify things later.

jedel1043 commented 2 months ago

Right, this won't pass CI until we fix https://github.com/charmed-hpc/slurm-snap/issues/47

NucciTheBoss commented 2 months ago

Right, this won't pass CI until we fix charmed-hpc/slurm-snap#47

Yeah... I think it's time for slurmhelpers to go :disappointed:

NucciTheBoss commented 2 months ago

@jedel1043 is this PR ready for another review, or are you still working on implementation the configuration management? We could follow on with that in a separate PR since we still need to implement the deb manager, and that PR will give us a better idea of how that implementation needs to shape up.

jedel1043 commented 2 months ago

@NucciTheBoss We need to integrate slurmutils to make CI pass 😅 Currently working on the update operation for slurmutils.

NucciTheBoss commented 2 months ago

@NucciTheBoss We need to integrate slurmutils to make CI pass 😅 Currently working on the update operation for slurmutils.

Bout ready to go YOLO and nuke slurmhelpers from the Slurm snap

jedel1043 commented 1 month ago

Wow... CI passed...

NucciTheBoss commented 1 month ago

This is looking great @jedel1043 :tada:

I just replied to your comment about the kebab casing for config-server, and I'm good with keeping the individual service managers.

NucciTheBoss commented 1 month ago

On second thought, it would probably be better to implement the deb manager before bumping version. That way the lib is "complete" before building it into the Slurm charms.