search

charmed-hpc / slurm-charms

Juju charms for automating the Day 0 to Day 2 operations of the Slurm workload manager ⚖️🐧
Apache License 2.0
1 stars 5 forks source link

test: add additional integration checks #12

Closed jedel1043 closed 3 months ago

jedel1043 commented 3 months ago

Combines all the checks from the integration tests of all the charms.

NucciTheBoss commented 3 months ago

@jedel1043 I don't think we want to disallow base branch updates?

image

NucciTheBoss commented 3 months ago

I needed to untick this restriction so that I can merge this PR. We should figure out what branch protections we want to set in place. If we do want to disallow base branch updates, we should at least add the @charmed-hpc/charmed-hpc-core-devs have bypass privileges for that specific rule but still require that CI succeeds. That way maintainers who aren't considered core devs can't mess with the base branch.

image