search

charmed-hpc / slurm-charms

Juju charms for automating the Day 0 to Day 2 operations of the Slurm workload manager ⚖️🐧
Apache License 2.0
0 stars 3 forks source link

custom configuration parser blows up when configuration values contain nested key/val pairs #14

Closed jamesbeedy closed 3 weeks ago

jamesbeedy commented 1 month ago

Bug Description

Custom configuration parser doesn't account for nested k=v type configuration.

To Reproduce

deploy the slurm charms and set juju config slurmctld slurm-conf-parameters='JobAcctGatherFrequency="task=1"'

Environment

slurm charms deployed from edge

Relevant log output

na

Additional context

No response

NucciTheBoss commented 1 month ago

Hi @jamesbeedy -

Thank you for this report! We should be able to address this relatively easily. Code in slurmutils is capable of handling this syntax.

jamesbeedy commented 1 month ago

Hi @jamesbeedy -

Thank you for this report! We should be able to address this relatively easily. Code in slurmutils is capable of handling this syntax.

I've always been +1 for slurmutils, but I didn't think it could initialize a config object from from a python dict, which was what I thought was blocking us initially ... if I recall correctly

NucciTheBoss commented 1 month ago

I've always been +1 for slurmutils, but I didn't think it could initialize a config object from from a python dict, which was what I thought was blocking us initially ... if I recall correctly

I have good news for you then. Guess what we're planning on doing this week :smile: