search

charmed-kubernetes / actions-operator

Apache License 2.0
7 stars 18 forks source link

Install Tox at system level #12

Closed johnsca closed 3 years ago

johnsca commented 3 years ago

Not all runners will have ~/.local/bin on the PATH by default, so Tox should be installed at the system level.

Cynerva commented 3 years ago

Any idea what's up with the failing microk8s and microstack tests? Are they expected to fail right now? It looks like they're unrelated to the changes in this PR but I have no idea what's going on.

johnsca commented 3 years ago

Even though the microstack case is still failing, since it's used less than LXD or microk8s, I'd like to get this merged and those fixed and merged and we can work on the microstack issue going forward.

vicamo commented 3 years ago

Besides, https://github.com/charmed-kubernetes/actions-operator/commit/b12e61c31691d2b375381316699e08fa5d45e265 added new conditions for branch main, and yet main is not even exist in this repository. As result pull requests to master will never trigger CI.

johnsca commented 3 years ago

@vicamo Thanks, I meant to rename the primary branch and missed that. Fixed now.

Edit: Actually, e673f54 was also included as a stop-gap, but not reason to not go ahead and do the rename.

vicamo commented 3 years ago

@vicamo Thanks, I meant to rename the primary branch and missed that. Fixed now.

Edit: Actually, e673f54 was also included as a stop-gap, but not reason to not go ahead and do the rename.

Hi, thank you for picking this up. But actually deleting master branch fails all existing downstream projects, if any. I think maybe we'd prefer a more considerate way, taking advantages of revisions, to prevent breaking people's projects unsolicitedly. After all, this project is meant for wide use, isn't it?