search

charmed-kubernetes / actions-operator

Apache License 2.0
7 stars 18 forks source link

Adds optional addons for microk8s #33

Closed claudiubelu closed 1 year ago

claudiubelu commented 2 years ago

In order to be able to use the nginx-ingress-integrator charm and other related charms, we need to enable ingress in microk8s.

This adds the microk8s-addons option, which will contain the addons to be enabled in microk8s. If not given, the default addons will be added instead (storage, dns, rbac).

Fixes: https://github.com/charmed-kubernetes/actions-operator/issues/32

ca-scribner commented 2 years ago

My only concern is whether there are any cases where ingress is undesired (does it break or conflict with anything?). Not sure who is best to make that call but putting the question out

claudiubelu commented 2 years ago

My only concern is whether there are any cases where ingress is undesired (does it break or conflict with anything?). Not sure who is best to make that call but putting the question out

I've updated PR to be configurable. Now, the microk8s-addons can be specified with the needed addons.

Sample run with this change: https://github.com/claudiubelu/waltz-integration-juju/runs/5719117283?check_suite_focus=true (triggered after pushing https://github.com/claudiubelu/waltz-integration-juju/commit/0c7a31571565786abf07f7d9db3b9e8f58d173f8).

ca-scribner commented 1 year ago

superseded by #46