charmed-kubernetes / actions-operator

Apache License 2.0
7 stars 18 forks source link

Update default addon (storage) #56

Open beliaev-maksim opened 1 year ago

addyess commented 1 year ago

@beliaev-maksim what's the reason for the change here?

@neoaggelos should this differ based on the version of microk8s installed?

beliaev-maksim commented 1 year ago

@addyess 1.24 is the latest version supported. And in this version we already should use different syntax, in 1.27-28 it should be removed entirely

addyess commented 1 year ago

this change would likely cause trouble with users who have old microk8s versions pinned:

If someone wishes to change the addons in a specific configuration, one can just use the microk8s-addons option available in the action:

  integration-test:
    runs-on: ubuntu-22.04
    steps:
    - name: Check out code
      uses: actions/checkout@v2
    - name: Setup operator environment
      uses: charmed-kubernetes/actions-operator@main
      with:
        provider: microk8s
        channel: 1.27/stable
        microk8s-addons: "hostpath-storage dns rbac"
beliaev-maksim commented 1 year ago

@addyess should not people who use old unsupported versions pin a version of the action, eg 1.1.0 ?

addyess commented 1 year ago

@addyess should not people who use old unsupported versions pin a version of the action, eg 1.1.0 ?

its my understanding that the the storage alias isn't going away anytime soon and is still safe to use in 1.27 and 1.28

beliaev-maksim commented 1 year ago

@addyess why does microk8s report a warning saying it is deprecated ?