charmed-kubernetes / actions-operator

Apache License 2.0
7 stars 18 forks source link

fix: Install jq from deb to support arm64 #78

Closed ghislainbourgeois closed 6 months ago

ghislainbourgeois commented 6 months ago

This changes the action to install jq from the apt repository instead of a snap, to enable the action to work on arm64.

The action currently installs jq from a specific snap revision that only exists for amd64. There is a jq deb in main; it is supported on more architectures and is more up to date.

The snap also exists for arm64, but we would have to track the latest/stable track. This could change more often than the deb package, which is why I propose this change with the deb instead.

addyess commented 6 months ago

@ghislainbourgeois I came here to do exactly the same thing and found you'd already done it. We need to build the js though and commit into the repo. See the contributors guide

addyess commented 6 months ago

Let's get this done ASAP!

ghislainbourgeois commented 6 months ago

@addyess I just pushed the commit. I had to use the environment variable that I found in #55 for things to build however.

addyess commented 6 months ago

@addyess I just pushed the commit. I had to use the environment variable that I found in #55 for things to build however.

💯 That's the one

addyess commented 6 months ago

@addyess I just pushed the commit. I had to use the environment variable that I found in #55 for things to build however.

💯 That's the one

@ghislainbourgeois

Okay yeah... Lemme look at this in the morning. Juju-bundle and juju-crashdump are gonna complain too. They are pinned to the amd64 versions too for security bc using a channel can present a security issue

addyess commented 6 months ago

closing in favor of #79