charmed-kubernetes / kubernetes-dashboard-operator

Kubernetes dashboard operator. Report bugs at https://bugs.launchpad.net/kubernetes-dashboard-operator
Apache License 2.0
0 stars 2 forks source link

Remove python cryptography libraries in favor of subprocess to `openssl` #79

Closed addyess closed 1 year ago

addyess commented 1 year ago

Trying to deploy this charm to arm64 resulted in something fairly broken

Much of it was the fact that charmcraft packs binary packages into the charm for cryptography. That library was driven by the charm's need to generate a self-signed cert.

So -- this PR addresses the inclusion of cryptography by using openssl and subprocess to generate certs in an arch agnostic way.

jnsgruk commented 1 year ago

I might be tempted to remove this functionality completely and just implement the tls-certificates interface - that way the charm will be able to get certs from vault, or statically from the tls-certificates-operator

addyess commented 1 year ago

@jnsgruk yes, i will do that in a following PR. I have the code prepared for that, just wanted to wait for a separate PR