Currently build_charm returns Optional[Path] while the comment next to the return statement suggests that it return "one of built paths" (in case of multiple bases).
I suspect that returning None means an error or, alternatively, can never happen,
Meanwhile charm integration tests rely on this function to return a Path, e.g. like so:
Currently build_charm returns
Optional[Path]
while the comment next to the return statement suggests that it return "one of built paths" (in case of multiple bases).I suspect that returning None means an error or, alternatively, can never happen,
Meanwhile charm integration tests rely on this function to return a Path, e.g. like so:
I'm proposing that if charm file cannot be found, this function raises an error, and the return type would be a (mandatory) Path.