Open NucciTheBoss opened 1 year ago
Hi there @addyess - thank you for the initial round of reviews. I will work through them as I have the time :smile: Either way, we should get folks off of using juju-bundle
to deploy bundles via pytest_operator. I will most likely get to it later this week or next depending on how the pulse lines up.
Hi there @addyess - thank you for the initial round of reviews. I will work through them as I have the time smile Either way, we should get folks off of using
juju-bundle
to deploy bundles via pytest_operator. I will most likely get to it later this week or next depending on how the pulse lines up.
Cool, i can agree with getting off juju-bundle
. I dunno who it would break. Just wanna make sure it doesn't break me :D
Description
This pull request aims to fix the issues that I identified in issue #98. Here is the summary of modifications that I made below:
build_bundle
method to usecharmcraft pack
rather thanjuju-bundle
. It now returns a Path object that points to where the built bundle zip archive is stored.build_bundles
method to build bundles asynchronously .deploy_bundle
to usejuju deploy ...
rather thanjuju-bundle
.render_bundle
to also accept the .tmpl file extension. I also enhanced the robustness of the expression. The original regex would match inputs such asxyamlij2
,Byaml
, etc since "." means any character. I modified it so that the regex would only accept the "." character.Related issues
Miscellaneous
I updated the
.gitignore
file to ignore the.idea
directory. I made this modification since I use PyCharm. I also added a hashbang and copyright information to the top ofplugin.py
.