search

charmedlabs / pixy2

Other
131 stars 98 forks source link

Avoid using pointer in the removed ListNode. #15

Open jimaobian opened 5 years ago

jimaobian commented 5 years ago

https://github.com/charmedlabs/pixy2/blob/bb27239a26a61a4e8a072a75b9ded97be2c2edc9/src/device/main_m4/src/line.cpp#L1722

This should be avoid. Please try to move it after using it:

SimpleListNode<Line2> *linen0 = j->m_object.m_lines[0];
SimpleListNode<Line2> *linen1 = j->m_object.m_lines[1];
g_intersectionsList.remove(j);
if (linen0->m_object.m_i0==j)